Differential D20719

LinuxKPI rcu list additions
ClosedPublic
Actions

Authored by johalun on Jun 21 2019, 4:31 PM.

Tags

None

Subscribers

Details

Reviewers

Commits

rS366889: MFC r349277 and r366669:
rS350083: MFC r349277:
rS349277: LinuxKPI: Additions to rcu list.

Summary

Add rcu list functions and change hlist_for_each_entry_rcu to use rcu and not the non-rcu version hlist_for_each_entry.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

johalun created this revision.Jun 21 2019, 4:31 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 21 2019, 4:31 PM

hselasky added inline comments.Jun 21 2019, 4:41 PM

sys/compat/linuxkpi/common/include/linux/rculist.h
36 ↗	(On Diff #58865)	<tab> after #define
39 ↗	(On Diff #58865)	wrap this line like the other ones
43 ↗	(On Diff #58865)	Missing ()'s &(pos)->member *(pos)
72 ↗	(On Diff #58865)	Missing ()'s (pos) != NULL

Add () where needed. Make sure define is followed by a tab.

johalun marked 3 inline comments as done.Jun 21 2019, 5:05 PM

johalun added inline comments.

sys/compat/linuxkpi/common/include/linux/rculist.h
39 ↗	(On Diff #58865)	I follow the style of the hlist_* equivalents below... Still want me to wrap this one?

Also bump freebsd version so we can have a checkpoint from where the virtualbox drm driver builds.

Looks good.

This revision is now accepted and ready to land.Jun 21 2019, 6:35 PM

Closed by commit rS349277: LinuxKPI: Additions to rcu list. (authored by johalun). · Explain WhyJun 21 2019, 6:48 PM

This revision was automatically updated to reflect the committed changes.

johalun added a commit: rS349277: LinuxKPI: Additions to rcu list..

johalun added a commit: rS350083: MFC r349277:.Jul 17 2019, 4:34 PM

hselasky added a commit: rS366889: MFC r349277 and r366669:.Oct 20 2020, 8:40 AM

Herald added a subscriber: linuxkpi. · View Herald TranscriptOct 20 2020, 8:40 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linuxkpi/

common/

include/

linux/

27 lines

sys/

2 lines

Diff 58871

head/sys/compat/linuxkpi/common/include/linux/rculist.h

Loading...

head/sys/sys/param.h

Loading...