Page MenuHomeFreeBSD

MFC 348757: nvdimm: Provide nvdimm location information
Needs RevisionPublic

Authored by scottph on Jun 14 2019, 9:36 PM.

Details

Reviewers
jhb
emaste
imp
Summary

Provide the acpi handle path as the location string for the nvdimm
children of the nvdimm_root device.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 24855
Build 23604: arc lint + arc unit

Event Timeline

scottph created this revision.Jun 14 2019, 9:36 PM
emaste accepted this revision.Jun 15 2019, 8:36 AM
emaste added a subscriber: emaste.

It looks like Phabricator will report that there are property changes on the directory but does not show the details - you can confirm that svn diff shows this metadata change:

Index: .
===================================================================
--- .   (revision 349048)
+++ .   (working copy)

Property changes on: .
___________________________________________________________________
Modified: svn:mergeinfo
## -0,0 +0,1 ##
   Merged /head:r348757
This revision is now accepted and ready to land.Jun 15 2019, 8:36 AM
imp requested changes to this revision.Jun 15 2019, 4:10 PM
imp added inline comments.
sys/dev/nvdimm/nvdimm.c
574

Don't do this. All entries must be foo=bar for the parser to be happy. If it is unknown, report nothing: *buf = '\0';

This revision now requires changes to proceed.Jun 15 2019, 4:10 PM
emaste added inline comments.Wed, Jun 19, 1:53 PM
sys/dev/nvdimm/nvdimm.c
574

Note that this review is for the MFC, the change is already in head, review D20528.

Path forward is to make the change in head, then MFC both together.

scottph added inline comments.Sun, Jun 23, 1:22 PM
sys/dev/nvdimm/nvdimm.c
574

@imp, thanks for pointing that out. I was following acpi's method https://svnweb.freebsd.org/base/head/sys/dev/acpica/acpi.c?revision=347984&view=markup#l853

I'll send a change for both of these and then squash that into this MFC.