Page MenuHomeFreeBSD

Unnecessary Include Header Removal
ClosedPublic

Authored by kfv on Jun 14 2019, 2:16 PM.
Tags
None
Referenced Files
F168396213: D20637.diff
Fri, Aug 28, 12:30 AM
Unknown Object (File)
Wed, Aug 26, 11:40 AM
Unknown Object (File)
Wed, Aug 26, 12:32 AM
Unknown Object (File)
Tue, Aug 25, 6:57 PM
Unknown Object (File)
Mon, Aug 10, 10:22 AM
Unknown Object (File)
Mon, Aug 10, 9:47 AM
Unknown Object (File)
Wed, Aug 5, 4:14 AM
Unknown Object (File)
Tue, Aug 4, 6:03 AM
Subscribers

Details

Summary

`libjail/jail.c' has included both <sys/param.h> and <sys/types.h> wherein the latter is unnecessary since it's already included by <sys/param.h>.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I approve of this change. But since I have not committed in a while, want to get sign-off from at least one other person.

@rgrimes @cem If one of you approve, I'll go ahead and usher it in

(<sys/param.h> includes <sys/types.h>; do not include both.)

style(9)

Macro shipit:

This revision is now accepted and ready to land.Jun 15 2019, 12:43 AM