Page MenuHomeFreeBSD

Restore commentary lost in r349203
ClosedPublic

Authored by dougm on Jun 14 2019, 2:04 AM.

Details

Summary

Critical comments were lost in r349203. This patch seeks to restate what was lost. It does not copy the lost comments directly, and I'm happy to hear feedback on how to improve it, other than the feedback that I should copy exactly what was there before, because those comments were somewhat awkwardly stated and needed improvement anyway.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dougm created this revision.Jun 14 2019, 2:04 AM
dougm updated this revision to Diff 58610.Jun 14 2019, 3:42 AM

Separate the comments and code blocks for 'create backing object' from 'clone entry'.

dougm updated this revision to Diff 58611.Jun 14 2019, 3:53 AM

Leave out unrelated patches.

kib accepted this revision.Jun 14 2019, 1:06 PM
This revision is now accepted and ready to land.Jun 14 2019, 1:06 PM
alc added inline comments.Jun 14 2019, 4:24 PM
vm_map.c
2263 ↗(On Diff #58611)

"Split off the back portion. Insert the new ...

dougm updated this revision to Diff 58631.Jun 14 2019, 4:31 PM

Apply reviewer suggestion.

This revision now requires review to proceed.Jun 14 2019, 4:31 PM
alc accepted this revision.Jun 14 2019, 9:21 PM
This revision is now accepted and ready to land.Jun 14 2019, 9:21 PM
This revision was automatically updated to reflect the committed changes.