Differential D20608

Fix PPC970 boot after r348783
ClosedPublic
Actions

Authored by bdragon on Jun 11 2019, 5:00 PM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Apr 30, 11:34 PM

	Unknown Object (File)
	Tue, Apr 30, 11:16 PM

	Unknown Object (File)
	Tue, Apr 30, 11:14 PM

	Unknown Object (File)
	Tue, Apr 30, 11:14 PM

	Unknown Object (File)
	Tue, Apr 30, 8:23 PM

	Unknown Object (File)
	Sun, Apr 21, 3:47 PM

	Unknown Object (File)
	Dec 27 2023, 8:43 PM

	Unknown Object (File)
	Dec 20 2023, 2:22 AM

View All 19 Files

Subscribers

Details

Reviewers

jhibbits
luporl

Commits

rS348994: Fix PPC970 boot after r348783

Summary

r348783 changed the behavior of the kernel mappings and broke booting on G5.

Split the kernel mapping logic out so that the case where we are running from the wrong memory space is handled using identity mappings, and the case where we are not using a DMAP is handled by forcibly mapping the kernel into the dmap range as intended by r348783.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Jun 11 2019, 5:00 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 11 2019, 5:00 PM

Looks good, thanks for fixing this.
I've tested this on QEMU, both with and without huge pages and it worked fine.

This revision is now accepted and ready to land.Jun 11 2019, 5:19 PM

jhibbits added inline comments.Jun 11 2019, 6:20 PM

sys/powerpc/aim/mmu_oea64.c
697–698 ↗	(On Diff #58534)	style(9) issue here. Keep the else if on the same line as the closing brace.

mikael added a subscriber: mikael.Jun 11 2019, 6:59 PM

fix style(9) issue.

This revision now requires review to proceed.Jun 11 2019, 8:01 PM

bdragon marked an inline comment as done.Jun 11 2019, 8:01 PM

jhibbits accepted this revision.Jun 12 2019, 3:18 AM

This revision is now accepted and ready to land.Jun 12 2019, 3:18 AM

No more kernel panic on my g5 with this patch. Thanks for the quick fix!

Closed by commit rS348994: Fix PPC970 boot after r348783 (authored by bdragon). · Explain WhyJun 12 2019, 3:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

aim/

12 lines

Diff 58564

head/sys/powerpc/aim/mmu_oea64.c

Loading...