Differential D2058

Reduce diffs between the three copies of libstand's Makefile
ClosedPublic
Actions

Authored by emaste on Mar 13 2015, 5:52 AM.

Details

Reviewers

jhb
imp

Commits

rS281886: Reduce diffs between the three copies of libstand's Makefile

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 4205.Mar 13 2015, 5:52 AM

emaste retitled this revision from to Reduce diffs between the three copies of libstand's Makefile.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: jhb, imp.

emaste added inline comments.

sys/boot/userboot/libstand/Makefile
72–73 ↗	(On Diff #4205)	It looks like powerpc userboot would not have worked correctly due to this one.

Definitely an improvement. I'm not sure I wouldn't prefer to use LIBC for the libc-pulling bits in all three though. Also, it would be really nice to have a 'Makefile.stand' or 'stand.mk' that all three of these included that included most of these guts (perhaps you are planning to do that next?)

LIBC_SRC as suggested by @jhb

Also wrap one > 80 col line while here.

Next stop: src/lib/libstand/Makefile.libstand (or the like) that all three variants can .include. :)

This revision is now accepted and ready to land.Apr 22 2015, 10:06 PM

In D2058#42752, @jhb wrote:

Next stop: src/lib/libstand/Makefile.libstand (or the like) that all three variants can .include. :)

Yes - I see three parts to converging these:

reduce gratuitous formatting etc. differences (this change) - this should have no functional change
address functional differences between the three (e.g. nandfs is missing from some, some have different compiler flags or arch support)
converge on a single source for the three libstands