Page MenuHomeFreeBSD

Style MAP_ENTRY_ and MAP_ definitions.
ClosedPublic

Authored by kib on Jun 8 2019, 7:44 PM.

Details

Summary

Spell all bits in the hex constants.
Since all lines are modified, consistently use <tab> after #define.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib created this revision.Jun 8 2019, 7:44 PM
alc accepted this revision.Jun 8 2019, 8:05 PM

I only wish that the options to mmap(2) and the vm_map operations didn't use the same prefix, i.e., "MAP_". :-(

This revision is now accepted and ready to land.Jun 8 2019, 8:05 PM
dougm added inline comments.Jun 8 2019, 8:07 PM
sys/vm/vm_map.h
143 ↗(On Diff #58412)

Capitalizing Top and Bottom is inconsistent with the rest.

kib updated this revision to Diff 58413.Jun 8 2019, 8:22 PM

Lowercase comments.

This revision now requires review to proceed.Jun 8 2019, 8:22 PM
dougm accepted this revision.Jun 8 2019, 8:23 PM
This revision is now accepted and ready to land.Jun 8 2019, 8:23 PM
This revision was automatically updated to reflect the committed changes.