Differential D20444

strip: Optimize for insertions at the tail of the section list.
ClosedPublic
Actions

Authored by markj on May 28 2019, 3:29 PM.

Tags

None

Referenced Files

	F171039415: D20444.id58075.diff
	Tue, Sep 8, 8:26 AM

	Unknown Object (File)
	Sun, Sep 6, 10:23 AM

	Unknown Object (File)
	Sun, Sep 6, 6:00 AM

	Unknown Object (File)
	Sat, Sep 5, 7:07 PM

	Unknown Object (File)
	Sat, Sep 5, 6:34 PM

	Unknown Object (File)
	Sat, Sep 5, 6:34 PM

	Unknown Object (File)
	Sat, Sep 5, 3:07 PM

	Unknown Object (File)
	Sat, Sep 5, 2:04 PM

View All Files

Subscribers

imp

Details

Reviewers

emaste
kaiw
jkoshy_users.sourceforge.net

Commits

rS348431: elfcopy: Optimize for insertions at the end of the section list.

Summary

This is the common case, so we can avoid a potentially expensive walk of
the section list.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 28 2019, 3:29 PM

Harbormaster completed remote builds in B24560: Diff 57995.May 28 2019, 3:29 PM

markj added reviewers: emaste, kaiw, jkoshy_users.sourceforge.net.May 28 2019, 3:30 PM

LGTM

This revision is now accepted and ready to land.May 28 2019, 4:48 PM

Closed by commit rS348431: elfcopy: Optimize for insertions at the end of the section list. (authored by markj). · Explain WhyMay 30 2019, 3:29 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 30 2019, 3:29 PM

dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

elfcopy/

elfcopy.h

2 lines

sections.c

10 lines

Diff 58075

View Options

head/contrib/elftoolchain/elfcopy/elfcopy.h