Differential D20428

ixl(4): fix the code not guarded by the guarded by the if clause
ClosedPublic
Actions

Authored by lwhsu on May 27 2019, 3:02 PM.

Tags

None

Referenced Files

	F154029071: D20428.id57955.diff
	Sat, Apr 25, 2:25 PM

	F153958452: D20428.id57955.diff
	Sat, Apr 25, 2:37 AM

	Unknown Object (File)
	Fri, Apr 24, 9:00 AM

	Unknown Object (File)
	Sun, Apr 19, 9:42 PM

	Unknown Object (File)
	Sun, Apr 19, 9:41 PM

	Unknown Object (File)
	Sun, Apr 12, 7:21 PM

	Unknown Object (File)
	Thu, Apr 9, 11:14 PM

	Unknown Object (File)
	Thu, Apr 9, 8:00 PM

View All Files

Subscribers

imp

Details

Reviewers

erj

Commits

rS360304: MFC r348445 (by lwhsu):
rS348445: Add the missing braces to fix the code not guarded by the if clause and has

Summary

Fix the code not guarded by the guarded by the if clause and has misleading
indentation. This is found by gcc -Wmisleading-indentation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lwhsu created this revision.May 27 2019, 3:02 PM

Herald added subscribers: ae, imp. · View Herald TranscriptMay 27 2019, 3:02 PM

Harbormaster completed remote builds in B24537: Diff 57955.May 27 2019, 3:02 PM

Add explicit braces to avoid dangling else (-Werror,-Wdangling-else of clang)

Harbormaster completed remote builds in B24546: Diff 57973.May 27 2019, 10:13 PM

This is fine -- this was a result of our code stripping process, I think.

This revision is now accepted and ready to land.May 29 2019, 10:25 PM

Closed by commit rS348445: Add the missing braces to fix the code not guarded by the if clause and has (authored by lwhsu). · Explain WhyMay 30 2019, 8:42 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rS360304: MFC r348445 (by lwhsu):.Apr 25 2020, 1:14 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ixl/

i40e_common.c

5 lines

Diff 58092

View Options

head/sys/dev/ixl/i40e_common.c

ixl(4): fix the code not guarded by the guarded by the if clauseClosedPublicActions