Page MenuHomeFreeBSD
Differential D20386

Make pmap_kextract() operational over the large map.
ClosedPublic
Actions

Authored by kib on May 23 2019, 6:41 PM.
Tags
None
Referenced Files
F103506251: D20386.id57866.diff
Mon, Nov 25, 9:05 PM
Unknown Object (File)
Wed, Nov 20, 10:46 PM
Unknown Object (File)
Tue, Nov 5, 3:24 PM
Unknown Object (File)
Thu, Oct 31, 3:49 PM
Unknown Object (File)
Oct 18 2024, 12:42 AM
Unknown Object (File)
Oct 7 2024, 12:03 AM
Unknown Object (File)
Oct 3 2024, 8:38 AM
Unknown Object (File)
Oct 1 2024, 6:43 AM
View All 35 Files
Subscribers
imp

Details

Reviewers
alc
markj
dougm
Commits
rS348258: Fix too loose assert in pmap_large_unmap().
rS348257: Add PG_PS_PDP_FRAME symbol.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.May 23 2019, 6:41 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 23 2019, 6:41 PM
Harbormaster completed remote builds in B24445: Diff 57788.May 23 2019, 6:41 PM
markj added inline comments.May 24 2019, 3:21 PM
sys/amd64/amd64/pmap.c
2965 ↗(On Diff #57788)

I think it should be va < LARGEMAP_MIN_ADDRESS + NBPML4 * lm_ents. pmap_large_unmap() seems to have the same bug in a kassert.

8799 ↗(On Diff #57788)

Maybe call it PG_PS1G_FRAME or PG_PSPDP_FRAME? I do not insist on giving it a name at all.

kib updated this revision to Diff 57847.May 24 2019, 4:46 PM

Use symbolic name for 1G superpage frame mask.
Fix upper boundary check for large map.

Harbormaster completed remote builds in B24476: Diff 57847.May 24 2019, 4:46 PM
markj accepted this revision.May 24 2019, 6:04 PM
markj added inline comments.
sys/amd64/amd64/pmap.c
8931 ↗(On Diff #57847)

The expression now appears in three places, maybe rename LARGEMAP_MAX_ADDRESS to LARGEMAP_STATIC_MAX_ADDRESS or so, and add

#define LARGEMAP_MAX_ADDRESS() (LARGEMAP_MIN_ADDRESS + NBPML4 * (u_long)lm_ents
This revision is now accepted and ready to land.May 24 2019, 6:04 PM
kib updated this revision to Diff 57866.May 24 2019, 9:57 PM
kib marked an inline comment as done.

LARGEMAP_RT_MAX_ADDRESS

This revision now requires review to proceed.May 24 2019, 9:58 PM
Harbormaster completed remote builds in B24489: Diff 57866.May 24 2019, 9:58 PM
alc added inline comments.May 24 2019, 10:38 PM
sys/amd64/amd64/pmap.c
424–425 ↗(On Diff #57866)

When I see LARGEMAP_RT_MAX_ADDRESS used, I'm going to think that it is a constant. Since it is not, I would suggest using a function-like name, e.g., pmap_large_map_<foo>().

sys/amd64/include/pmap.h
122 ↗(On Diff #57866)

I think that an '_' between the PS and PDP would help.

kib updated this revision to Diff 57871.May 24 2019, 10:48 PM
kib marked 2 inline comments as done.

PMAP_LARGEMAP_MAX_ADDRESS()
PG_PS_PDP_FRAME

Harbormaster completed remote builds in B24492: Diff 57871.May 24 2019, 10:48 PM
markj accepted this revision.May 24 2019, 10:51 PM
This revision is now accepted and ready to land.May 24 2019, 10:51 PM
alc accepted this revision.May 24 2019, 10:59 PM
Closed by commit rS348257: Add PG_PS_PDP_FRAME symbol. (authored by kib). · Explain WhyMay 24 2019, 11:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
include/
1 line

Diff 57874

View Options

head/sys/amd64/include/pmap.h

Loading...