Page MenuHomeFreeBSD

DTrace: fix reading a 64-bits register on amd64
ClosedPublic

Authored by oshogbo on May 22 2019, 7:48 PM.

Details

Summary

The registers in ilumos and FreeBSD have a different number.
In the illumos, last 32-bits register defined is SS an in FreeBSD is GS.
This off-by-one caused the uregs array to returns the wrong 64-bits register
on amd64.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

oshogbo created this revision.May 22 2019, 7:48 PM
markj accepted this revision.May 22 2019, 9:10 PM
markj added inline comments.
sys/cddl/dev/dtrace/amd64/dtrace_isa.c
519 ↗(On Diff #57718)

I wouldn't bother with the comment in such a small block.

This revision is now accepted and ready to land.May 22 2019, 9:10 PM
This revision was automatically updated to reflect the committed changes.
Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptJun 5 2019, 10:29 PM
Herald added a subscriber: imp. · View Herald Transcript