Build the kernel with -z notext.
ClosedPublic
Actions

Authored by markj on May 14 2019, 3:31 PM.

Details

Reviewers

emaste
kib

Commits

rS347570: Specify -z notext when building with -z ifunc-noplt.

Summary

The upstream implementation of -z ifunc-noplt disallows the combination
of -z text and -z ifunc-noplt. With this change DT_TEXTREL will be set
in the kernel executable, but AFAIK the change is effectively a no-op.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 14 2019, 3:31 PM

Harbormaster completed remote builds in B24234: Diff 57390.May 14 2019, 3:31 PM

markj edited the summary of this revision. (Show Details)May 14 2019, 3:34 PM

markj added reviewers: emaste, kib.

kib accepted this revision.May 14 2019, 3:55 PM

This revision is now accepted and ready to land.May 14 2019, 3:55 PM

BTW would it be better to use the -Wl,-z,notext -Wl,-z,ifunc-noplt syntax ?

In D20260#436661, @kib wrote:

BTW would it be better to use the -Wl,-z,notext -Wl,-z,ifunc-noplt syntax ?

Yes, or even -Wl,-z,notext,-z,ifunc-noplt. But at least the -z and its arg should be in the same -Wl, IMO.

In D20260#436664, @emaste wrote:

In D20260#436661, @kib wrote:

BTW would it be better to use the -Wl,-z,notext -Wl,-z,ifunc-noplt syntax ?

Yes, or even -Wl,-z,notext,-z,ifunc-noplt. But at least the -z and its arg should be in the same -Wl, IMO.

Heh, I did not notice before that we are modifying LDFLAGS, not CFLAGS. So -Wl is entirely redundant and kib's suggested syntax does not work. I will remove -Wl first in a separate commit.

Closed by commit rS347570: Specify -z notext when building with -z ifunc-noplt. (authored by markj). · Explain WhyMay 14 2019, 6:26 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2019, 6:26 PM