Differential D20244

nullfs: lock the vnode with LK_SHARED in null_vptocnp
ClosedPublic
Actions

Authored by mjg on May 12 2019, 2:46 AM.

Details

Reviewers

Commits

rS351360: nullfs: lock the vnode with LK_SHARED in null_vptocnp

Summary

null_nodeget which follows almost always finds the target vnode in the hash, avoiding insmntque1 altogether. Should it be needed, it already checks if the lock needs to be upgraded.

This shows up as one of contending places during poudriere runs.

Tested by: pho

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.May 12 2019, 2:46 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 12 2019, 2:46 AM

Harbormaster completed remote builds in B24210: Diff 57328.May 12 2019, 2:46 AM

This requires a removal of the KASSERT() in null_nodeget() for the NULLM_CACHE flag.

Did pho tested the change ?

remove the (now) wrong assertion

He did just now (along with something else).

kib accepted this revision.Aug 21 2019, 10:13 PM

This revision is now accepted and ready to land.Aug 21 2019, 10:13 PM

Closed by commit rS351360: nullfs: lock the vnode with LK_SHARED in null_vptocnp (authored by mjg). · Explain WhyAug 21 2019, 11:25 PM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rS351360: nullfs: lock the vnode with LK_SHARED in null_vptocnp.

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

nullfs/

null_subr.c

3 lines

null_vnops.c

6 lines

Diff 61100

View Options

head/sys/fs/nullfs/null_subr.c