Page MenuHomeFreeBSD

nullfs: lock the vnode with LK_SHARED in null_vptocnp
ClosedPublic

Authored by mjg on May 12 2019, 2:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 18 2024, 1:15 PM
Unknown Object (File)
Jan 5 2024, 5:40 PM
Unknown Object (File)
Dec 20 2023, 12:06 AM
Unknown Object (File)
Nov 16 2023, 8:17 AM
Unknown Object (File)
Aug 27 2023, 6:31 PM
Unknown Object (File)
Aug 27 2023, 5:08 PM
Unknown Object (File)
Aug 7 2023, 9:29 AM
Unknown Object (File)
Jun 13 2023, 3:30 PM
Subscribers

Details

Summary

null_nodeget which follows almost always finds the target vnode in the hash, avoiding insmntque1 altogether. Should it be needed, it already checks if the lock needs to be upgraded.

This shows up as one of contending places during poudriere runs.

Tested by: pho

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 24210

Event Timeline

This requires a removal of the KASSERT() in null_nodeget() for the NULLM_CACHE flag.

Did pho tested the change ?

mjg edited the summary of this revision. (Show Details)
  • remove the (now) wrong assertion

He did just now (along with something else).

This revision is now accepted and ready to land.Aug 21 2019, 10:13 PM
This revision was automatically updated to reflect the committed changes.