Page MenuHomeFreeBSD

nullfs: lock the vnode with LK_SHARED in null_vptocnp
Needs ReviewPublic

Authored by mjg on May 12 2019, 2:46 AM.

Details

Reviewers
kib
Summary

null_nodeget which follows almost always finds the target vnode in the hash, avoiding insmntque1 altogether. Should it be needed, it already checks if the lock needs to be upgraded.

This shows up as one of contending places during poudriere runs.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 24210

Event Timeline

mjg created this revision.May 12 2019, 2:46 AM
kib added a comment.May 12 2019, 8:20 AM

This requires a removal of the KASSERT() in null_nodeget() for the NULLM_CACHE flag.

Did pho tested the change ?