Page MenuHomeFreeBSD

nullfs: lock the vnode with LK_SHARED in null_vptocnp
ClosedPublic

Authored by mjg on May 12 2019, 2:46 AM.

Details

Summary

null_nodeget which follows almost always finds the target vnode in the hash, avoiding insmntque1 altogether. Should it be needed, it already checks if the lock needs to be upgraded.

This shows up as one of contending places during poudriere runs.

Tested by: pho

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mjg created this revision.May 12 2019, 2:46 AM
kib added a comment.May 12 2019, 8:20 AM

This requires a removal of the KASSERT() in null_nodeget() for the NULLM_CACHE flag.

Did pho tested the change ?

mjg updated this revision to Diff 61092.Aug 21 2019, 9:29 PM
mjg edited the summary of this revision. (Show Details)
  • remove the (now) wrong assertion
mjg added a comment.Aug 21 2019, 9:29 PM

He did just now (along with something else).

kib accepted this revision.Aug 21 2019, 10:13 PM
This revision is now accepted and ready to land.Aug 21 2019, 10:13 PM
This revision was automatically updated to reflect the committed changes.