Address memory leaks in the libc posix1e code found by Coverity.

[pfg]

Summary

These look like memory leaks but I would like confirmation:
CID 1016705
CID 1016706
CID 1016707

Test Plan

Anything with ACLs

[trasz]

lib/libc/posix1e/acl_calc_mask.c

107 ↗

(On Diff #4136)

Shouldn't this be acl_free(acl_new) instead?

126 ↗

(On Diff #4136)

I know it's not in the patch, but it... looks curious. WTF?

lib/libc/posix1e/acl_strip.c

99 ↗

(On Diff #4136)

You should also free acl_old, right? Same in the next few cases.

116 ↗

(On Diff #4136)

... and here, and few below. Might be a good idea to replace all those "return (NULL)" with "goto fail" to avoid code duplication.

[pfg]

It is quite a mess, I was following blindly what Coverity reported.
I'll update the patch. thanks!

lib/libc/posix1e/acl_calc_mask.c

107 ↗

(On Diff #4136)

Yes, I got confused by Coverity as it reports acl_int_new is (also) leaked.

126 ↗

(On Diff #4136)

There's nothing here in "svn diff".

lib/libc/posix1e/acl_strip.c

86 ↗

(On Diff #4136)

Coverity flags this one because acl_old != NULL from line 78.
It looks like Coverity doesn't know about acl_init().

99 ↗

(On Diff #4136)

CID 1016705: From line 78 acl_new != NULL.
Coverity doesn't know about acl_get_entry().

[pfg]

This comment was removed by pfg.

[pfg]

This comment was removed by pfg.

[pfg]

It is much cleaner with the "fail" label.
(sorry for the spam)

[pfg]

Closed by commit rS279962 (authored by @pfg).