Add support for RK3399 emmc

[ganbold]

Summary

Add emmc support for Rockchip RK3399 SoC.

[manu]

It missed the phy, so currently this works because u-boot already setup it for us.

sys/dev/sdhci/sdhci_fdt.c

57 ↗

(On Diff #57033)

This needs to be undef ifdef EXT_RESOURCES.
Same comment for most of the thing below.

[andrew]

sys/dev/sdhci/sdhci_fdt.c

289 ↗

(On Diff #57033)

This should be moved from probe to attach.

[ganbold]

Updated. In case pf phy, we first maybe need separate driver for emmc-phy.

[ganbold]

Updated (phy enabled)

[ganbold]

Fix register definitions

[manu]

For rockchip there is a clock exposed (via the clock-output-names property) but you don't register it and you try to get it in the emmc-phy review (D20840).

This means that the sdhci driver should first expose the clock, wait for the phy driver with the help of newpass to be attached and then resume the work on sd/emmc detection.
I also think that you should subclass the driver since this will add a lot of rockchip related code.

[ganbold]

Updated accordingly.

[manu]

sys/dev/sdhci/sdhci_fdt.c

161 ↗

(On Diff #59802)

You should validate that this was the emmcclock that was requested based on the cells content and return ENXIO if it wasn't

481 ↗

(On Diff #59802)

phy_init(sc->phy);

[ganbold]

Updated accordingly.

[ganbold]

Looks like phydev_if.h is not needed, and no other functional changes.

[manu]

sys/dev/sdhci/sdhci_fdt.c

492 ↗

(On Diff #59861)

I would prefer this block to be in a deticated rockchip function.

161 ↗

(On Diff #59802)

You still don't validate the clock id based on cells[0] content.

[ganbold]

Added ncells check in rk3399_ofw_map() function according to comment.
Moved rk3399 sdhci init related codes into sdhci_init_rk3399() function so that it looks more clean.