Differential D20066

Stop checking for TD_IDLETHREAD() in the buffer cache.
ClosedPublic
Actions

Authored by markj on Apr 26 2019, 6:15 AM.

Details

Reviewers

kib
mckusick

Commits

rS346888: Stop checking TD_IDLETHREAD() in buffer cache routines.

Summary

The checks seems to be vestigal; an idle thread cannot execute these
code paths. For example, an idle thread is not permitted to acquire
locks.

Cache curthread in bread(). No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 26 2019, 6:15 AM

Harbormaster completed remote builds in B23915: Diff 56686.Apr 26 2019, 6:15 AM

markj added reviewers: kib, mckusick.Apr 26 2019, 7:27 AM

Wouldn't the same argument apply to the getblkx() use of the predicate ?

In D20066#431505, @kib wrote:

Wouldn't the same argument apply to the getblkx() use of the predicate ?

Indeed, I missed that one somehow.

Remove another always-false check.

Harbormaster completed remote builds in B23920: Diff 56693.Apr 26 2019, 7:40 AM

kib accepted this revision.Apr 26 2019, 7:51 AM

This revision is now accepted and ready to land.Apr 26 2019, 7:51 AM

A useful cleanup.

Closed by commit rS346888: Stop checking TD_IDLETHREAD() in buffer cache routines. (authored by markj). · Explain WhyApr 29 2019, 1:23 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptApr 29 2019, 1:23 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_bio.c

48 lines

Diff 56805

View Options

Stop checking for TD_IDLETHREAD() in the buffer cache.ClosedPublicActions