Page MenuHomeFreeBSD

[PPC64] Fix wrong KASSERT in mphyp_pte_insert()
ClosedPublic

Authored by luporl on Apr 22 2019, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 9, 8:54 PM
Unknown Object (File)
Wed, Sep 9, 4:36 PM
Unknown Object (File)
Wed, Sep 9, 2:49 AM
Unknown Object (File)
Tue, Sep 8, 8:02 PM
Unknown Object (File)
Tue, Sep 8, 5:41 PM
Unknown Object (File)
Tue, Sep 8, 4:53 PM
Unknown Object (File)
Tue, Sep 8, 4:51 PM
Unknown Object (File)
Tue, Sep 8, 3:55 PM

Details

Summary

As mphyp_pte_unset() can also remove PTE entries, and as this can
happen in parallel with PTEs evicted by mphyp_pte_insert(), there
is a (rare) chance the PTE being evicted gets removed before
mphyp_pte_insert() is able to do so. Thus, the KASSERT should
check wether the result is H_SUCCESS or H_NOT_FOUND, to avoid
panics if the situation described above occurs.

More details about this issue can be found in PR 237470.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable