Page MenuHomeFreeBSD

[PowerPC64] fix pseries llan driver not working on ELFv2 ABI kernel
ClosedPublic

Authored by alfredo on Apr 22 2019, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 1:19 AM
Unknown Object (File)
Feb 25 2025, 11:39 AM
Unknown Object (File)
Feb 8 2025, 5:13 PM
Unknown Object (File)
Feb 8 2025, 5:09 PM
Unknown Object (File)
Jan 19 2025, 10:27 AM
Unknown Object (File)
Jan 12 2025, 2:36 PM
Unknown Object (File)
Jan 2 2025, 10:39 PM
Unknown Object (File)
Jan 2 2025, 9:40 PM

Details

Summary

Network interface driver pseries-llan wasn't working on kernel compiled for ELFv2 ABI.
The hyper call "H_SEND_LOGICAL_LAN" [1] returned H_HARDWARE (error) instead of H_SUCCESS, as wrong value for "continue-token" parameter was being received from the driver.

The root cause was identified as the incorrect offset of "Stack Frame - Parameter Save Area" on ELFv2 ABI, that's SP+32 instead of SP+48 [2].

[1] LoPAPR_DRAFT_v11_24March2016 - 16.4.3.5 H_SEND_LOGICAL_LAN
[2] 2.2.2. The Stack Frame - http://openpowerfoundation.org/wp-content/uploads/resources/leabi/content/dbdoclet.50655240___RefHeading___Toc377640582.html#dbdoclet.50655240_97610

Test Plan

Test network interface on QEMU-PowerPC64 with kernel built with both ELFv1 and ELFv2 ABIs

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable