PR: 230289 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> (initial revision) meta (myself) Reported by: #Reviewed by: Approved by: Obtained from: MFC after: MFH: Relnotes: Security: Sponsored by: #Differential Revision: https://reviews.freebsd.org/D20000
Details
Details
- Reviewers
sunpoet - Group Reviewers
Ruby O5: Ports Framework (Owns No Changed Paths) portmgr - Commits
- rP500480: lang/ruby2[45]: Remove dbm library and replace it with databases/rubygem-dbm
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 23924 Build 22844: arc lint + arc unit
Event Timeline
databases/rubygem-dbm/Makefile | ||
---|---|---|
18 | I think you could simplify the option names by removing BACKEND_ prefix. | |
21–32 | Please group settings of each option (e.g. BDB_*) together. It's easier to read. And it's easier to find out duplicate or conflicts, e.g. duplicate BACKEND_BDB_USES in line 21 and 27. | |
36–39 | It is not needed. This gem does not require libunwind. | |
databases/rubygem-dbm/pkg-descr | ||
25 | Please use https://github.com/ruby/dbm (the homepage link of this gem). | |
lang/ruby24/Makefile | ||
136 | I would like to keep it in the same order (ext/dbm ext/gdbm) as the pkg-message. |
Comment Actions
- Replace WWW with GitHub
- Remove BACKEND_ prefix from options and duplicate definitions
- Remove unnecessary dependency on libunwind
- Sort modules in Makefile
databases/rubygem-dbm/Makefile | ||
---|---|---|
32 | IIUC, it should be LOCALBASE, not PREFIX. |