Page MenuHomeFreeBSD

lang/ruby2[45]: Remove dbm library and replace it with databases/rubygem-dbm
ClosedPublic

Authored by meta on Apr 22 2019, 3:40 AM.

Details

Summary
PR:		230289
Submitted by:	Yasuhiro KIMURA <yasu@utahime.org> (initial revision)
		meta (myself)
Reported by:
#Reviewed by:
Approved by:
Obtained from:
MFC after:
MFH:
Relnotes:
Security:
Sponsored by:
#Differential Revision:	https://reviews.freebsd.org/D20000

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23807
Build 22751: arc lint + arc unit

Event Timeline

meta added a reviewer: Ruby.

Added some ruby people and who is on the CC list of original PR.

sunpoet requested changes to this revision.Apr 22 2019, 6:09 PM
sunpoet added inline comments.
databases/rubygem-dbm/Makefile
17

I think you could simplify the option names by removing BACKEND_ prefix.

20–31

Please group settings of each option (e.g. BDB_*) together. It's easier to read.

And it's easier to find out duplicate or conflicts, e.g. duplicate BACKEND_BDB_USES in line 21 and 27.

35–38

It is not needed. This gem does not require libunwind.

databases/rubygem-dbm/pkg-descr
24

Please use https://github.com/ruby/dbm (the homepage link of this gem).

lang/ruby24/Makefile
136

I would like to keep it in the same order (ext/dbm ext/gdbm) as the pkg-message.

This revision now requires changes to proceed.Apr 22 2019, 6:09 PM
  • Replace WWW with GitHub
  • Remove BACKEND_ prefix from options and duplicate definitions
  • Remove unnecessary dependency on libunwind
  • Sort modules in Makefile
databases/rubygem-dbm/Makefile
31

IIUC, it should be LOCALBASE, not PREFIX.

This revision is now accepted and ready to land.Apr 26 2019, 1:21 PM
This revision was automatically updated to reflect the committed changes.