PR: 230289 Submitted by: Yasuhiro KIMURA <yasu@utahime.org> (initial revision) meta (myself) Reported by: #Reviewed by: Approved by: Obtained from: MFC after: MFH: Relnotes: Security: Sponsored by: #Differential Revision: https://reviews.freebsd.org/D20000
Details
Details
- Reviewers
sunpoet - Group Reviewers
Ruby O5: Ports Framework portmgr - Commits
- rP500480: lang/ruby2[45]: Remove dbm library and replace it with databases/rubygem-dbm
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| databases/rubygem-dbm/Makefile | ||
|---|---|---|
| 17 ↗ | (On Diff #56464) | I think you could simplify the option names by removing BACKEND_ prefix. |
| 20–31 ↗ | (On Diff #56464) | Please group settings of each option (e.g. BDB_*) together. It's easier to read. And it's easier to find out duplicate or conflicts, e.g. duplicate BACKEND_BDB_USES in line 21 and 27. |
| 35–38 ↗ | (On Diff #56464) | It is not needed. This gem does not require libunwind. |
| databases/rubygem-dbm/pkg-descr | ||
| 24 ↗ | (On Diff #56464) | Please use https://github.com/ruby/dbm (the homepage link of this gem). |
| lang/ruby24/Makefile | ||
| 136 ↗ | (On Diff #56464) | I would like to keep it in the same order (ext/dbm ext/gdbm) as the pkg-message. |
Comment Actions
- Replace WWW with GitHub
- Remove BACKEND_ prefix from options and duplicate definitions
- Remove unnecessary dependency on libunwind
- Sort modules in Makefile
| databases/rubygem-dbm/Makefile | ||
|---|---|---|
| 31 ↗ | (On Diff #56520) | IIUC, it should be LOCALBASE, not PREFIX. |