Differential D19825

Set the oppid field of orphans when exiting.
ClosedPublic
Actions

Authored by markj on Apr 5 2019, 12:50 AM.

Tags

None

Referenced Files

	F173810851: D19825.id55821.diff
	Mon, Sep 28, 3:07 PM

	Unknown Object (File)
	Wed, Sep 23, 3:20 PM

	Unknown Object (File)
	Sun, Sep 20, 2:01 PM

	Unknown Object (File)
	Fri, Sep 18, 3:46 PM

	Unknown Object (File)
	Thu, Sep 17, 2:25 AM

	Unknown Object (File)
	Sat, Sep 5, 4:11 PM

	Unknown Object (File)
	Sat, Sep 5, 3:02 PM

	Unknown Object (File)
	Sat, Sep 5, 7:53 AM

View All Files

Subscribers

emaste

imp

Details

Reviewers

kib
mjg

Commits

rS346009: Set the p_oppid field of orphans when exiting.

Summary

Such processes will be reparented to the reaper when the current parent
is done with them; oppid must be updated accordingly. Otherwise, the
p->p_oppid != p->p_pptr->p_pid check in proc_reap() will always fail.

Test Plan

Peter tested the patch.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 5 2019, 12:50 AM

Herald added a subscriber: emaste. · View Herald TranscriptApr 5 2019, 12:50 AM

Harbormaster completed remote builds in B23524: Diff 55821.Apr 5 2019, 12:50 AM

markj edited the test plan for this revision. (Show Details)Apr 5 2019, 12:52 AM

markj added reviewers: kib, mjg.

mjg accepted this revision.Apr 5 2019, 12:57 AM

This revision is now accepted and ready to land.Apr 5 2019, 12:57 AM

kib accepted this revision.Apr 5 2019, 9:09 AM

Closed by commit rS346009: Set the p_oppid field of orphans when exiting. (authored by markj). · Explain WhyApr 7 2019, 2:26 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptApr 7 2019, 2:26 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_exit.c

5 lines

tests/

sys/

kern/

ptrace_test.c

62 lines

Diff 55904

View Options

head/sys/kern/kern_exit.c