Page MenuHomeFreeBSD

Fix timeout-related panics in MPR and MPS
ClosedPublic

Authored by scottl on Mar 22 2019, 2:02 PM.

Details

Summary

r329522 created problemss with commands that enter the TIMEDOUT state but
are successfully returned by the card (usually due to an abort being issued
as part of timeout recovery). Remove what amounts to an insufficient
KASSERT, and don't overwrite the state value. State should probably be
re-designed, and that will be done with a future commit.

This bug was encountered by two independent sources, and both reported
that this patch fixed the problem.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

scottl created this revision.Mar 22 2019, 2:02 PM
scottl updated this revision to Diff 55347.Mar 22 2019, 2:04 PM

Add mpr too

imp accepted this revision.Mar 22 2019, 2:04 PM

Does MPR need a similar fix?

This revision is now accepted and ready to land.Mar 22 2019, 2:04 PM
imp added a comment.Mar 22 2019, 2:05 PM

derp... I missed you did both...

mav accepted this revision.Mar 22 2019, 4:58 PM

Makes sense to me on a quick look.