Page MenuHomeFreeBSD
Differential D19606

Use GitHub to build lang/erlang* ports
ClosedPublic
Actions

Authored by olgeni on Mar 16 2019, 11:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 6, 8:41 PM
Unknown Object (File)
Mon, Jan 6, 1:31 PM
Unknown Object (File)
Thu, Dec 26, 6:53 PM
Unknown Object (File)
Sun, Dec 22, 5:58 AM
Unknown Object (File)
Sun, Dec 22, 5:57 AM
Unknown Object (File)
Dec 5 2024, 8:43 PM
Unknown Object (File)
Nov 29 2024, 4:13 AM
Unknown Object (File)
Nov 26 2024, 4:11 AM
View All Files
Subscribers
mat

Details

Reviewers
jrm
feld
dch
swills
Commits
rP498548: lang/erlang, -wx, -java: update to version 19.3.6.13.
Summary

Right now, updating any of the Erlang ports requires generating patches manually from the git repo, hosting them somewhere, and hosting the prebuilt BEAM files without which the build can fail in mysterious and unexpected ways.

By removing all hosted files, lang/erlang will behave like a "normal" port at last. Also, the big Wx configure patches can go away.

Casualties: erlang-wx is no longer able to build demo.erl, but that's really minor.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olgeni created this revision.Mar 16 2019, 11:17 AM
Herald added a subscriber: mat. · View Herald TranscriptMar 16 2019, 11:17 AM
Harbormaster completed remote builds in B23129: Diff 55136.Mar 16 2019, 11:17 AM
olgeni edited the summary of this revision. (Show Details)Mar 16 2019, 11:20 AM
olgeni added reviewers: jrm, feld, dch.
olgeni added a reviewer: swills.
mat added a comment.Mar 16 2019, 1:53 PM

The comments apply to the three Makefiles.

lang/erlang-java/Makefile
26 ↗(On Diff #55136)

Remove, default.

28 ↗(On Diff #55136)
DISTVERSIONPREFIX= OTP-
32 ↗(On Diff #55136)

Remove, default. (There should be a warning telling you so.)

olgeni updated this revision to Diff 55139.Mar 16 2019, 5:35 PM

Misc. port fixes plus upgrade to 19.3.6.13.

Harbormaster completed remote builds in B23131: Diff 55139.Mar 16 2019, 5:35 PM
olgeni updated this revision to Diff 55141.Mar 16 2019, 7:16 PM

Fix typo (pre-configure-{MX->WX}-off).

Harbormaster completed remote builds in B23132: Diff 55141.Mar 16 2019, 7:16 PM
olgeni added a comment.Mar 16 2019, 8:56 PM

Working on a few more fixes..

olgeni updated this revision to Diff 55161.Mar 17 2019, 4:10 PM

Moved all WX-dependent applications to lang/erlang-wx, plus more small fixes.

Harbormaster completed remote builds in B23141: Diff 55161.Mar 17 2019, 4:10 PM
dch requested changes to this revision.Mar 26 2019, 7:48 AM

minor tweaks to download sites.

Also, I suggest we bump to 20.3.8.20 (latest I could find) already when committing this.

lang/erlang-java/Makefile
9 ↗(On Diff #55161)

neither of the additional MASTER_SITES actually have a www site anymore. Let's drop them.

10 ↗(On Diff #55161)

likewise

37 ↗(On Diff #55161)

shouldn't this be --without-wx

lang/erlang-wx/Makefile
9 ↗(On Diff #55161)

drop

10 ↗(On Diff #55161)

drop

lang/erlang/Makefile
10 ↗(On Diff #55161)

drop

11 ↗(On Diff #55161)

drop

43 ↗(On Diff #55161)

can we add a note that from 22 onwards HIPE should be removed from defaults due to lacking support for all opcodes?

This revision now requires changes to proceed.Mar 26 2019, 7:48 AM
olgeni updated this revision to Diff 55453.Mar 26 2019, 2:14 PM
olgeni marked 9 inline comments as done.

Added all the relevant fixes.

I would like to proceed like this:

  • Switch everything to GitHub (runtimes too)
  • Split erlang-man to get rid of the extra distfile here
  • Upgrade the port to either 20 or 21
  • Start deprecating lots of Erlang/Elixir library ports, like it was done for golang (same issues here)

Does it sound ok?

Harbormaster completed remote builds in B23304: Diff 55453.Mar 26 2019, 2:14 PM
olgeni added inline comments.Mar 27 2019, 1:31 AM
lang/erlang/Makefile
10 ↗(On Diff #55161)

We need to keep erlang.org for a bit more until I split erlang-man out of the port, then it can be dropped.

43 ↗(On Diff #55161)

Sure - I just saw it in the 22rc1 relnotes.

olgeni added inline comments.Mar 27 2019, 7:46 PM
lang/erlang/Makefile
43 ↗(On Diff #55161)

Afterthought - would this affect dialyzer?

dch accepted this revision.Mar 27 2019, 8:15 PM

ship it - I think hipe and dialyzer will need some care for 22 but we don’t have to fix it right now.

This revision is now accepted and ready to land.Mar 27 2019, 8:15 PM
mat added inline comments.Apr 1 2019, 12:14 PM
lang/erlang-java/Makefile
16 ↗(On Diff #55453)

You should remove ${LOCALBASE}/bin/ here and in all other DEPENDS lines.

23 ↗(On Diff #55453)

This should be the line after USE_GITHUB. (goes for all other ports too.)

olgeni updated this revision to Diff 55677.Apr 1 2019, 3:41 PM

GH and DEPENDS fixes.

This revision now requires review to proceed.Apr 1 2019, 3:41 PM
Harbormaster completed remote builds in B23439: Diff 55677.Apr 1 2019, 3:41 PM
olgeni marked 2 inline comments as done.Apr 1 2019, 3:42 PM
olgeni marked an inline comment as done.Apr 10 2019, 10:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2019, 10:23 AM
Closed by commit rP498548: lang/erlang, -wx, -java: update to version 19.3.6.13. (authored by olgeni). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lang/
erlang-java/
44 lines
42 lines
erlang-wx/
76 lines
42 lines
files/
10464 lines
1143 lines
erlang/
73 lines
44 lines
files/
10464 lines

Diff 56041

View Options

head/lang/erlang-java/Makefile

Loading...
View Options

head/lang/erlang-java/distinfo

Loading...
View Options

head/lang/erlang-wx/Makefile

Loading...
View Options

head/lang/erlang-wx/distinfo

Loading...
View Options

head/lang/erlang-wx/files/patch-lib_wx_configure

Loading...
View Options

head/lang/erlang-wx/pkg-plist

Loading...
View Options

head/lang/erlang/Makefile

Loading...
View Options

head/lang/erlang/distinfo

Loading...
View Options

head/lang/erlang/files/patch-lib_wx_configure

Loading...