Page MenuHomeFreeBSD

Round # partitions up to fill the last GPT table sector
ClosedPublic

Authored by marcel on Mar 5 2019, 5:50 AM.

Details

Summary

Set the number of entries in the GPT header to a multiple
of the number entries that fit in a sector.

PR: 236238

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 22892
Build 21978: arc lint + arc unit

Event Timeline

marcel created this revision.Mar 5 2019, 5:50 AM
imp accepted this revision.Mar 5 2019, 5:49 PM
This revision is now accepted and ready to land.Mar 5 2019, 5:49 PM
imp added a comment.Mar 5 2019, 5:50 PM

btw, I scrolled past the .uu files assuming they were correct.
Do we still need the uudecode dance? Though that would be a different commit

Yeah, I don't like the way we now have the master files. I think I was too much focussed on keeping the file size small and opted to compress, followed by uuencode. But it's a real pain to work with. For one, you can't diff the rebased files after a code change and see if the new behavior matches the expectation. And on top of that, diffs tend to be much bigger than a one-liner of the hexdump output.

I think I'd rather just have the output of "hexdump -C" as-is and not compress and not uuencode the compressed file.
I can definitely do that.
Sound good?

This revision was automatically updated to reflect the committed changes.