Page MenuHomeFreeBSD

Remove an unneeded 'tail -n 1' from a pipeline
ClosedPublic

Authored by • lidl on Mar 4 2019, 2:44 PM.
Tags
None
Referenced Files
F174569118: D19441.diff
Sun, Oct 4, 6:26 AM
Unknown Object (File)
Sun, Sep 27, 2:43 AM
Unknown Object (File)
Sat, Sep 26, 5:56 AM
Unknown Object (File)
Sun, Sep 20, 6:49 PM
Unknown Object (File)
Sun, Sep 20, 5:45 PM
Unknown Object (File)
Sun, Sep 20, 4:31 PM
Unknown Object (File)
Sun, Sep 20, 11:49 AM
Unknown Object (File)
Fri, Sep 11, 6:50 PM

Details

Summary

When piping to awk, it's almost always an anti-pattern to use 'grep' first.

When not in a pipeline, sometimes it is faster to use tail, as awk must process all the lines, and won't 'seek'. In a pipeline, both must process all lines, so we might as well skip the extra process creation and just use awk for all the processing.

Test Plan

Verify that the output between:

zpool list -v $rootdev | tail -n 1 | awk '{print $1}'

and

zpool list -v $rootdev | awk 'END {print $1}'

Are the same on all my systems. The output is the same.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable