Page MenuHomeFreeBSD

net-p2p/libswift: support OpenSSL 1.1.1
ClosedPublic

Authored by dch on Mar 2 2019, 9:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 9:31 PM
Unknown Object (File)
Tue, Mar 19, 5:33 PM
Unknown Object (File)
Fri, Mar 15, 12:53 AM
Unknown Object (File)
Fri, Mar 15, 12:53 AM
Unknown Object (File)
Fri, Mar 15, 12:53 AM
Unknown Object (File)
Fri, Mar 15, 12:49 AM
Unknown Object (File)
Fri, Mar 15, 12:49 AM
Unknown Object (File)
Mon, Mar 11, 9:16 AM
Subscribers
None

Details

Summary
  • thanks danfe@ for the upstreamed patch enabling this
  • portlint petting and tidy Makefile alignment
Test Plan

portlint, poudriere LGTM. tested binary on x64 only

11_2_x64
11_2_x86
12_0_armv6
12_0_armv7
12_0_x64
12_0_x86
current_x64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

net-p2p/libswift/Makefile
5 ↗(On Diff #54619)

You tagged a GH release, so this should be

DISTVERSIONPREFIX=	v
DISTVERSION=		0.1.0

then remove GH_TAGNAME=dc0cbcc below.

Also, does this make D17684 obsolete? If so, could you close D17684?

net-p2p/libswift/Makefile
5 ↗(On Diff #54619)

And you would have to bump PORTEPOC. Your choice.

dch marked 2 inline comments as done.Mar 3 2019, 3:14 PM
dch added inline comments.
net-p2p/libswift/Makefile
5 ↗(On Diff #54619)

I've removed the tag in favour of sticking with a date, as there's not a great deal of movement upstream, but I'll ask about picking up the repo ownership and if so, I'll tag it then.

add brief usage instructions

net-p2p/libswift/Makefile
5 ↗(On Diff #54619)

Sounds good. In this case, there is no distribution version, but you, as the port maintainer, are making up a version, so it should be PORTVERSION=20190302. See Example 5.9. Exotic Case 2 in the PH.

net-p2p/libswift/pkg-descr
9–18 ↗(On Diff #54638)

Is this more appropriate for pkg-message or documentation?

19 ↗(On Diff #54638)

The GitHub page seems more appropriate than the RFC for WWW.

dch marked 3 inline comments as done.May 21 2019, 10:55 PM

fix nits, add pkg-message

This revision is now accepted and ready to land.May 22 2019, 4:16 PM
This revision was automatically updated to reflect the committed changes.