Make isp(4) suggest loading ispfw(4) when it fails to attach.

[trasz]

Summary

Make isp(4) suggest loading ispfw(4) when it fails to attach.
It cannot load it automatically at boot, because the root filesystem
is not there yet. An alternative would be adding ispfw(4) to GENERIC,
but it's an additional 1MB.

[mav]

I think generally it may be not a bad idea, but I'd prefer less exact message, like "Consider loading ispfw kernel module for known good firmware".

Also you could add check for card generation, since there is no public firmware images for 16Gbps cards and above, so the message would not have sense.

[trasz]

Don't print stuff for 16Gb HBAs.

[trasz]

Thanks. Does it look ok now?

Regarding the message - why? I quite like the current one, because it tells you exactly what you need to do, instead of having to figure it out.

[mav]

In D19369#416253, @trasz wrote:

Regarding the message - why? I quite like the current one, because it tells you exactly what you need to do, instead of having to figure it out.

Because it tells you what to do (may happen to be incorrect for somebody), not explaining why.

[ken]

I think it would actually be better to add the suggestion to put in ispfw_load whenever the user isn't on a 16Gb board and hasn't loaded firmware.

In most cases, we'll probably have the newest firmware in the kernel. And certainly the firmware that has been tested with the driver.

[trasz]

I believe we might be close to automatically loading those by loader(8) itself. And that would make this advice redundant soon.

[trasz]

Better message.