Differential D19329

address possible illegal SACK block after FIN when client keeps sending data
AbandonedPublic
Actions

Authored by rscheff on Feb 24 2019, 1:52 PM.

Details

Reviewers

Group Reviewers

Summary

If the socket option SBS_CANTRCVMORE is set, TCP will discard the received data, but update rcv_nxt.
Futhermore, not adjusting the actually accepted length could lead to illegal SACK blocks.

However, the impact seems minor, as that socket flag is only set once a FIN is received, and data beyond FIN is not expected.

Logically, we are not accepting the data...

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22690
Build 21790: arc lint + arc unit

Event Timeline

rscheff created this revision.Feb 24 2019, 1:52 PM

Herald added a reviewer: transport. · View Herald TranscriptFeb 24 2019, 1:52 PM

Harbormaster completed remote builds in B22690: Diff 54300.Feb 24 2019, 1:52 PM

rscheff retitled this revision from don't update rcv_nxt if socket can not receive. to address possible illegal SACK block after FIN when client keeps sending data.Feb 24 2019, 2:06 PM

rscheff edited the summary of this revision. (Show Details)

rscheff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 24 2019, 2:06 PM

tuexen added a reviewer: tuexen.Jul 27 2019, 2:22 AM

rscheff abandoned this revision.Jun 24 2020, 3:06 PM

Herald added a subscriber: melifaro. · View Herald TranscriptJun 24 2020, 3:06 PM