Page MenuHomeFreeBSD

Dynamically allocate per-cpu scheduler state
ClosedPublic

Authored by jeff on Feb 24 2019, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 6, 5:00 AM
Unknown Object (File)
Thu, Sep 25, 7:51 AM
Unknown Object (File)
Fri, Sep 19, 6:59 AM
Unknown Object (File)
Fri, Sep 19, 6:51 AM
Unknown Object (File)
Fri, Sep 19, 6:42 AM
Unknown Object (File)
Fri, Sep 19, 6:37 AM
Unknown Object (File)
Fri, Sep 19, 6:29 AM
Unknown Object (File)
Fri, Sep 19, 6:23 AM
Subscribers

Details

Summary

We want to allocate scheduler state dynamically so that it can be allocated to the correct NUMA domain. This also eliminates a global and statically sized MAXCPU state array.

I added a per-cpu variable to point at dpcpu allocated memory to keep the instruction bloat down. This actually makes TDQ_SELF() more efficient than it was before but TDQ_CPU() is less efficient.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Can you re-upload the diff with the full context added, please ?

Much cleaner, as usual, than the hack I gave you to start with.

This revision is now accepted and ready to land.Feb 25 2019, 4:48 PM
In D19315#413467, @kib wrote:

Can you re-upload the diff with the full context added, please ?

+1, it is painful to review diffs without context.

Am I right that in head, dpcpu area allocations are not yet NUMA-affinitized?

kern/sched_ule.c
315 ↗(On Diff #54278)

It's called "id" in the definition.

Am I right that in head, dpcpu area allocations are not yet NUMA-affinitized?

Yes, it is just kmem_malloc() in mp_machdep.c:native_start_all_aps().