Page MenuHomeFreeBSD

Document proccontrol(1). Add documentation about ASLR to procctl(2).
ClosedPublic

Authored by kib on Feb 23 2019, 12:01 PM.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

juan.molina_club.fr added inline comments.
lib/libc/sys/procctl.2
76 ↗(On Diff #54253)

s/Layour/Layout

kib marked an inline comment as done.Feb 26 2019, 9:39 AM
0mp requested changes to this revision.Feb 26 2019, 11:58 AM
0mp added a subscriber: 0mp.
0mp added inline comments.
lib/libc/sys/procctl.2
86 ↗(On Diff #54253)

Macros are not expanded in the argument provided to -width (in this case ("Dv PROC_ASLR_FORCE_DISABLE")).

It is enough to write "PROC_ASLR_FORCE_DISABLE" or even PROC_ASLR_FORCE_DISABLE.

105 ↗(On Diff #54253)

Macros are not expanded in the argument provided to -width (in this case ("Dv PROC_ASLR_FORCE_DISABLE")).

It is enough to write "PROC_ASLR_FORCE_DISABLE" or even PROC_ASLR_FORCE_DISABLE.

usr.bin/proccontrol/proccontrol.1
59 ↗(On Diff #54253)

Ar trapcap is not going to be expanded. It's better to just write: .Bl -tag -width trapcap

This revision now requires changes to proceed.Feb 26 2019, 11:58 AM

Remove Dv from .Bl width arg.

(The cleanup of old .Bl would be a separate commit, to avoid further questions).

OK from manpages.

lib/libc/sys/procctl.2
83 ↗(On Diff #54414)

Is Xa the correct macro name?

This revision is now accepted and ready to land.Feb 26 2019, 4:25 PM
This revision was automatically updated to reflect the committed changes.