Page MenuHomeFreeBSD

Use iconv to ensure the output of calendar respects the output encoding
ClosedPublic

Authored by bapt on Feb 17 2019, 10:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 3:30 PM
Unknown Object (File)
Nov 24 2024, 1:41 PM
Unknown Object (File)
Nov 21 2024, 3:04 PM
Unknown Object (File)
Nov 21 2024, 1:59 PM
Unknown Object (File)
Nov 20 2024, 5:46 AM
Unknown Object (File)
Nov 20 2024, 5:41 AM
Unknown Object (File)
Nov 18 2024, 4:26 PM
Unknown Object (File)
Nov 14 2024, 6:39 PM
Subscribers

Details

Summary

Use iconv to ensure the output of calendar respects the output encoding

Test Plan

tested with french and russian calendars

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jilles added inline comments.
usr.bin/calendar/calendar.c
90–95 ↗(On Diff #54008)

Perhaps nl_langinfo(CODESET) is better than hard-coding the locale name format.

usr.bin/calendar/events.c
83 ↗(On Diff #54008)

Style: the open brace should be on a line by itself.

198 ↗(On Diff #54008)

This strdup is unnecessary. The pointer can be saved instead and freed after the asprintf.

bapt marked an inline comment as done.

Fix style

bapt marked 2 inline comments as done.Feb 17 2019, 3:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2019, 6:41 AM
This revision was automatically updated to reflect the committed changes.