Page MenuHomeFreeBSD

Add dash as a valid characterl to UFS label name
ClosedPublic

Authored by marck on Jan 27 2019, 10:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 6:51 AM
Unknown Object (File)
Fri, Apr 26, 5:41 AM
Unknown Object (File)
Mar 25 2024, 10:07 PM
Unknown Object (File)
Jan 10 2024, 3:41 AM
Unknown Object (File)
Nov 23 2023, 6:36 PM
Unknown Object (File)
Nov 11 2023, 2:36 PM
Unknown Object (File)
Nov 8 2023, 4:39 PM
Unknown Object (File)
Nov 8 2023, 7:09 AM

Details

Summary

Most file systems and disk labeling schemes allow dashes as a valid character
in their names. Examples are MSDOS, GPT, and ext*

However, current implementation of UFS does not allow dashes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp added a subscriber: 0mp.

OK form manpages, Make sure to bump the date in the manual pages when you commit.

sbin/tunefs/tunefs.c
193 ↗(On Diff #53270)

style(9)? It should be indented with 4 spaces instead, right?

This revision is now accepted and ready to land.Jan 27 2019, 12:38 PM
danfe added inline comments.
sbin/newfs/newfs.8
92 ↗(On Diff #53270)

Shouldn't it be dash and underscore (singular, not plural) in this context? Also, missing Oxford comma (before and).

sbin/tunefs/tunefs.8
115 ↗(On Diff #53270)

Here as well.

As noted, date at top of manual pages needs to be updated (which I will admit, I failed to do when I added underscores).

sbin/newfs/newfs.8
92 ↗(On Diff #53270)

Plural is correct. `Legal characters are' describes all the legal things that can appear in a label of which there may be multiple alphanumerics, multiple dashes, and multiple underscores.
I agree that there should be a comma after dashes.

sbin/tunefs/tunefs.8
115 ↗(On Diff #53270)

My same comment as above: leave plurals, add comma.

sbin/tunefs/tunefs.c
193 ↗(On Diff #53270)

Agreed, should be four spaces.

This revision now requires changes to proceed.Jan 27 2019, 9:03 PM

Update language/style, as requested.

Sorry, unrelated changes chime in. Hope to eliminate them now.

Ahh, missed Oxford commas in manual pages.

Now all should be fixed.

This revision is now accepted and ready to land.Jan 28 2019, 9:56 PM

Dashes in labels won't cause problems for geom or the boot loader, so I think this is a good change. Thanks for driving it.

Note that update of manual page date fell out on corrective update.

This revision was automatically updated to reflect the committed changes.