Page MenuHomeFreeBSD

Remove the unused and unusable MDIOCLIST ioctl.
ClosedPublic

Authored by brooks on Jan 24 2019, 12:13 AM.

Details

Summary

It is unused, the ABI was broken in r322969, and it is broken by design
(more than MDNPAD md devices can exist and there is no way to retreive
them with this interface).

mdconfig(8) was converted to use libgeom to obtain this information
in r157160 and any other consumers of MDIOCLIST should likewise be
converted.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brooks created this revision.Jan 24 2019, 12:13 AM

A search of dports for MDIOCLIST shows only on result (in a duplicate header) so I don't think an exp-run is required here https://grok.dragonflybsd.org/search?q=MDIOCLIST&defs=&refs=&path=&hist=&type=

kib added a comment.Jan 24 2019, 4:22 PM

Does the removal mean that we are unable to build some old releases in chroot ?

In D18936#404680, @kib wrote:

Does the removal mean that we are unable to build some old releases in chroot ?

Only for releases prior to rS157160 (March 2006) if they depend on being able to list all md(4) devices, but that was already broken in rS322969 when the ABI was broken by adding labels. I'd be surprised if anything depended on that. The usual pattern:

MD=`mdconfig -a ...`

should be unaffected.

emaste accepted this revision.Aug 16 2019, 4:26 PM
This revision is now accepted and ready to land.Aug 16 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.