Page MenuHomeFreeBSD

lang/rust: update to 1.32.0
ClosedPublic

Authored by jbeich on Jan 16 2019, 5:53 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich created this revision.Jan 16 2019, 5:53 PM
tobik added a subscriber: tobik.Jan 16 2019, 6:19 PM

Thank you, Jan. Can you crank the Rust version in cargo.mk too please?

lang/rust/files/patch-vendor_libc_src_unix_bsd_freebsdlike_dragonfly_mod.rs
1–7 ↗(On Diff #52896)

Why not svn mv these too?

jbeich updated this revision to Diff 52908.Jan 17 2019, 2:15 AM
jbeich edited the test plan for this revision. (Show Details)
  • Bump version for USES=cargo
  • Regen diff with --find-copies-harder (breaks download link)
jbeich added inline comments.Jan 17 2019, 2:22 AM
lang/rust/files/patch-vendor_libc_src_unix_bsd_freebsdlike_dragonfly_mod.rs
1–7 ↗(On Diff #52896)

I use Git which didn't detect this rename for some reason. Adding --find-copies-harder just after -C in ArcanistGitAPI.php didn't help. Any ideas?

Subversion sucks for batching multiple commits and due to facilitating mistakes and poor commit messages. If you really want me to use Subversion directly be prepared I might screw up with probability as high as 60% i.e., better if someone else lands it.

tobik accepted this revision.Jan 17 2019, 6:57 AM

I use Git which didn't detect this rename for some reason. Adding --find-copies-harder just after -C in ArcanistGitAPI.php didn't help. Any ideas?
Subversion sucks for batching multiple commits and due to facilitating mistakes and poor commit messages. If you really want me to use Subversion directly be prepared I might screw up with probability as high as 60% i.e., better if someone else lands it.

Thanks for explaining. It looked like a job half done to me because several files are in fact registered as being renamed. Before you fight the tools leave it be. It's not that important.

(For some reason Phabricator refuses to allow me to post this inline...)

This revision is now accepted and ready to land.Jan 17 2019, 6:57 AM
This revision was automatically updated to reflect the committed changes.