Page MenuHomeFreeBSD

Create crtsavres.o for powerpc builds
ClosedPublic

Authored by jhibbits on Jan 11 2019, 9:59 PM.

Details

Summary

GCC expects to link in a crtsavres.o on powerpc platforms. On
powerpc64 this is an empty file, but on powerpc and powerpcspe this does contain
some save/restore functions, which may not actually be necessary for newer
modern GCC and clang. This appeases the in-tree gcc, though.

Test Plan

buildworld

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhibbits created this revision.Jan 11 2019, 9:59 PM

You should remove crtsavres.o from gnu/lib/csu/Makefile

andrew added inline comments.Jan 12 2019, 10:12 AM
lib/csu/powerpc/crtsavres.S
9–11 ↗(On Diff #52785)

We've been moving to the BSD 1 clause license for crt code as it tends to end up in all binaries. See lib/csu/common/crtbegin.c for an example.

jhibbits updated this revision to Diff 52798.Jan 12 2019, 7:48 PM

Use the correct license.

jhibbits marked an inline comment as done.Jan 12 2019, 7:49 PM
jhibbits added inline comments.
lib/csu/powerpc/crtsavres.S
9–11 ↗(On Diff #52785)

Woops, sorry. Copied the wrong license header. Fixed now.

jhibbits updated this revision to Diff 52799.Jan 12 2019, 7:56 PM
jhibbits marked an inline comment as done.

Remove crtsavres.o from gnu/lib/csu.

andrew accepted this revision.Jan 12 2019, 8:44 PM
andrew added inline comments.
lib/csu/powerpc64/Makefile
5 ↗(On Diff #52799)

There's an extra space at the end of the line.

This revision is now accepted and ready to land.Jan 12 2019, 8:44 PM
This revision was automatically updated to reflect the committed changes.