Uses/pgsql.mk: PostgreSQL option to install a version between an interval

[lbartoletti]

Summary

As a postgis maintainer and other tools relying on postgresql, I need to define an interval for postgresql. This allows you to avoid errors like this one at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234813

I had proposed this patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213038 but it was not followed.

I propose this patch independently.

Once approved, I will modify my ports requiring intervals and update the documentation.

Thank you.

[crees]

I think this should work-- how have you tested this?

Uses/pgsql.mk

18

Please would you document it too? I'll deal with the Porter's Handbook bit.

92

_MIN=${pgsql_ARGS:M?*-?*:C,-.*,,}

Should work, but please test. Use ?* because * matches the empty string, which isn't a problem because of the elif but the test is incorrect; would match *- as well.

[lbartoletti]

In D18818#401664, @crees wrote:

I think this should work-- how have you tested this?

Yes, with some test on a fake port. However, I didn't try to compile all the ports using pgsql.mk

For example with pgsql9.5 installed and a port with

USES= pgsql:9.3-9.4

I get

version 9.3 9.4 and you have version 9.5 installed.
*** Error code 1

Stop.

USES= pgsql:9.6-11

The result is:

version 9.6 10 11 and you have version 9.5 installed.
*** Error code 1

Stop.

If I write:

USES= pgsql:9.6-9.3

I get:

The minimum version must be higher than the maximum version wanted.
*** Error code 1

Stop.

And if no pgsql is installed

USES= pgsql:9.6-11

installs postgresql9.6

[lbartoletti]

Rewriting documentation on version options. Application of the @crees suggestion for MIN

[crees]

Please get the MAX fixed too and it's great.

Uses/pgsql.mk

93

If you do this one too I'll commit it :)

[lbartoletti]

Change substitution also for MAX

[lbartoletti]

Uses/pgsql.mk

93

Oh yes, sorry!
Thank you :)

[crees]

Committed, thanks!

Uses/pgsql.mk

98

Point of curiosity, in former versions of make it had to be written as ${_MIN} <= ${version}

If you're ever writing portable code that's worth remembering:

https://www.freebsd.org/cgi/man.cgi?query=make&apropos=0&sektion=1&manpath=FreeBSD+8.3-RELEASE&arch=default&format=html#end