Page MenuHomeFreeBSD

Copy ^/head/.arcconfig to ^/vendor/.arcconfig
ClosedPublic

Authored by ngie on Dec 20 2018, 7:26 PM.

Details

Summary

Having a copy of .arcconfig in ^/vendor will allow developers to submit
reviews more easily using arc diff. Reviewing commits to ^/vendor has
not been standard operating procedure, as far as I can tell, but since I am
mentored and getting back up to speed, I needed to submit the review via
Phabricator.

Test Plan

I was able to submit the review via arc diff without specifying any of the
variables needed to do so.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ngie created this revision.Dec 20 2018, 7:26 PM
jtl accepted this revision.Jan 11 2019, 7:42 PM

LGTM

This revision is now accepted and ready to land.Jan 11 2019, 7:42 PM
jtl added a comment.Jan 11 2019, 7:44 PM

By the way, in the commit message, please make it clear that this simple "allows" you to more easily use arc if you want your changes to be reviewed. It doesn't require it in any way, shape, or form. And, we're not changing any expectations regarding when someone will get review.

This revision was automatically updated to reflect the committed changes.
ngie added a comment.Jan 11 2019, 10:21 PM
In D18621#401774, @jtl wrote:

By the way, in the commit message, please make it clear that this simple "allows" you to more easily use arc if you want your changes to be reviewed. It doesn't require it in any way, shape, or form. And, we're not changing any expectations regarding when someone will get review.

Agreed :).

I submitted the following commit message to clarify the points you brought up (thank you!):

Copy ^/head/.arcconfig to ^/vendor/.arcconfig

Having a copy of .arcconfig in ^/vendor will allow developers to submit
reviews more easily and in a manner consistent to submitting diffs (out of the
box) via `arc diff` in `^/head`. This change eliminates the need for setting
these values [globally] via `arc set-config`.

Approved by:	jtl (mentor)
Differential Revision:	https://reviews.freebsd.org/D18621