Page MenuHomeFreeBSD

Add some more checking to the page fault handler.
ClosedPublic

Authored by markj on Dec 14 2018, 8:07 PM.
Tags
None
Referenced Files
F138059509: D18561.diff
Fri, Nov 28, 1:49 PM
Unknown Object (File)
Tue, Nov 25, 6:31 PM
Unknown Object (File)
Sun, Nov 23, 5:12 PM
Unknown Object (File)
Sat, Nov 22, 6:36 PM
Unknown Object (File)
Sat, Nov 22, 4:27 AM
Unknown Object (File)
Thu, Nov 20, 7:53 PM
Unknown Object (File)
Thu, Nov 20, 7:50 PM
Unknown Object (File)
Thu, Nov 20, 7:49 PM
Subscribers

Details

Summary
  • Rename "lower" to "usermode" to make its meaning more clear. I am happy to revert this part if there is some reason "lower" is a better name, but I don't see one.
  • Panic immediately if witness says we're holding non-sleepable locks. This helps ensure that we don't recurse on the pmap lock in pmap_fault_fixup().
  • Panic if the kernel faults on a user address without setting an onfault handler.
  • Panic if the fault occurred in a critical section or interrupt handler, like we do on other platforms.
  • Use VM_MAX_USER_ADDRESS instead of checking the high bit in the fault address. I think the previous trick is too magical and makes it harder to change the address space layout if or when we decide to do so (e.g., switching to SV48).
  • Fix a few style issues.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21574
Build 20878: arc lint + arc unit