Page MenuHomeFreeBSD

Add some more checking to the page fault handler.
ClosedPublic

Authored by markj on Dec 14 2018, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 27, 12:14 PM
Unknown Object (File)
Sun, Mar 22, 4:37 PM
Unknown Object (File)
Sun, Mar 22, 4:37 AM
Unknown Object (File)
Fri, Mar 20, 6:34 AM
Unknown Object (File)
Thu, Mar 19, 3:07 AM
Unknown Object (File)
Thu, Mar 12, 2:19 PM
Unknown Object (File)
Thu, Mar 12, 10:12 AM
Unknown Object (File)
Mar 4 2026, 7:59 AM
Subscribers

Details

Summary
  • Rename "lower" to "usermode" to make its meaning more clear. I am happy to revert this part if there is some reason "lower" is a better name, but I don't see one.
  • Panic immediately if witness says we're holding non-sleepable locks. This helps ensure that we don't recurse on the pmap lock in pmap_fault_fixup().
  • Panic if the kernel faults on a user address without setting an onfault handler.
  • Panic if the fault occurred in a critical section or interrupt handler, like we do on other platforms.
  • Use VM_MAX_USER_ADDRESS instead of checking the high bit in the fault address. I think the previous trick is too magical and makes it harder to change the address space layout if or when we decide to do so (e.g., switching to SV48).
  • Fix a few style issues.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable