Paths

Table of Contentst

Differential D18511

Pass VM_PROT_EXECUTE to vm_fault for instruction faults
ClosedPublic
Actions

Authored by andrew on Dec 11 2018, 10:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 1:43 PM

	Unknown Object (File)
	Oct 9 2024, 2:34 AM

	Unknown Object (File)
	Sep 24 2024, 2:55 AM

	Unknown Object (File)
	Sep 23 2024, 10:22 PM

	Unknown Object (File)
	Sep 23 2024, 10:38 AM

	Unknown Object (File)
	Sep 23 2024, 12:17 AM

	Unknown Object (File)
	Sep 22 2024, 4:13 AM

	Unknown Object (File)
	Sep 21 2024, 9:39 PM

View All 47 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS352440: MFC r342552:
rS342552: Pass VM_PROT_EXECUTE to vm_fault for instruction faults.

Summary

We need to tell vm_fault the reason for the fault was because we tried
to execute from the memory location. Without this it may return with
success as we only request read-only memory, then we return to the same
location and try to execute from the same memory address. This leads to
an infinite loop raising the same fault and returning to the same
invalid location.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Dec 11 2018, 10:58 AM

Herald added a subscriber: emaste. · View Herald TranscriptDec 11 2018, 10:58 AM

Harbormaster completed remote builds in B21492: Diff 51862.Dec 11 2018, 10:58 AM

Seems reasonable.

sys/arm64/arm64/trap.c
154 ↗	(On Diff #51862)	How about `bool`?

andrew marked an inline comment as done.Dec 11 2018, 11:15 AM

andrew added inline comments.

sys/arm64/arm64/trap.c
154 ↗	(On Diff #51862)	I thought about that but decided to keep with the existing style, `lower` is also a bool.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 27 2018, 2:15 PM

Closed by commit rS342552: Pass VM_PROT_EXECUTE to vm_fault for instruction faults. (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2018, 2:15 PM

andrew added a commit: rS352440: MFC r342552:.Sep 17 2019, 10:01 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

arm64/

10 lines

Diff 52336

head/sys/arm64/arm64/trap.c

Loading...