Page MenuHomeFreeBSD

Several iov handling bugs in bhyve virtio-scsi backend
ClosedPublic

Authored by mav on Dec 6 2018, 10:24 PM.
Tags
None
Referenced Files
F168662438: D18465.diff
Sat, Aug 29, 12:22 PM
Unknown Object (File)
Fri, Aug 28, 9:32 AM
Unknown Object (File)
Thu, Aug 27, 12:16 PM
Unknown Object (File)
Wed, Aug 26, 2:15 PM
Unknown Object (File)
Tue, Aug 25, 11:27 AM
Unknown Object (File)
Tue, Aug 25, 1:58 AM
Unknown Object (File)
Mon, Aug 24, 2:35 PM
Unknown Object (File)
Mon, Aug 24, 2:12 PM
Subscribers

Details

Summary
  • buf_to_iov() does not use buflen parameter, allowing out of bound read.
  • buf_to_iov() leaks memory if seek argument > 0.
  • iov_to_buf() doesn't need to reallocate buffer for every segment.
  • there is no point to use size_t for iov counts, int is more then enough.
  • some iov function arguments can be constified.
  • pci_vtscsi_request_handle() used truncate_iov() incorrectly, allowing getting out of buffer and possibly corrupting data.
  • pci_vtscsi_controlq_notify() written returned status at wrong offset.
  • pci_vtscsi_controlq_notify() leaked one buffer per event.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable