Page MenuHomeFreeBSD

Make openssl111 equivalent to base on 12/13.
Needs ReviewPublic

Authored by mat on Dec 6 2018, 2:32 PM.

Details

Reviewers
brnrd
antoine
Group Reviewers
portmgr
Summary

While there, make BROKEN_SSL=base actually do something.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21560
Build 20864: arc lint + arc unit

Event Timeline

mat created this revision.Dec 6 2018, 2:32 PM
mat edited the summary of this revision. (Show Details)Dec 6 2018, 2:32 PM
mat added a reviewer: brnrd.Dec 12 2018, 12:53 PM
antoine requested changes to this revision.Dec 12 2018, 1:03 PM
antoine added a subscriber: antoine.

Some ports set BROKEN_SSL=openssl111 but build fine on head.

This revision now requires changes to proceed.Dec 12 2018, 1:03 PM
mat added a comment.Dec 12 2018, 3:00 PM

Some ports set BROKEN_SSL=openssl111 but build fine on head.

Mmmm, how does that happen?

In D18449#394897, @mat wrote:

Some ports set BROKEN_SSL=openssl111 but build fine on head.

Mmmm, how does that happen?

BROKEN_SSL spread all over the tree without testing?

mat added a comment.Dec 12 2018, 3:40 PM

Mmmm, ok, but outside of BROKEN_SSL being wrongly put there, do you have examples of ports that build with OpenSSL 1.1.1 from base but not from the port?

brnrd accepted this revision.Dec 12 2018, 7:51 PM

This superseeds D17834 ?

LGTM

mat updated this revision to Diff 51989.Dec 14 2018, 9:42 AM

rebase.