ssl.mk: Automate BROKEN for 12+
AbandonedPublic
Actions

Authored by brnrd on Nov 4 2018, 9:10 AM.

Details

Reviewers

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Summary

Mk/Uses/ssl.mk: Automate BROKEN for 12+

 - Add BROKEN for FreeBSD 12+ when broken with openssl111

Differential_Revision:	https://reviews.freebsd.org/D17834

Currently all ports marked BROKEN_SSL= openssl111 also require BROKEN_FreeBSD_12 and BROKEN_FreeBSD_13 entries, but only if DEFAULT_VERSIONS=ssl isn't openssl. This requires ugly contstructs like https://github.com/freebsd/freebsd-ports/commit/93c9ec82

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 20736
Build 20145: arc lint + arc unit

Event Timeline

brnrd created this revision.Nov 4 2018, 9:10 AM

Owners added a reviewer: O5: Ports Framework.Nov 4 2018, 9:10 AM

Herald added a reviewer: portmgr. · View Herald TranscriptNov 4 2018, 9:10 AM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B20622: Diff 49993.Nov 4 2018, 9:11 AM

brnrd mentioned this in D17136: Update BROKEN_SSL in ports.Nov 4 2018, 1:38 PM

brnrd marked an inline comment as done.Nov 8 2018, 5:32 PM

brnrd added inline comments.

Mk/Uses/ssl.mk
67	See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232944 Without modification, ports need changes like https://svnweb.freebsd.org/changeset/ports/483982

I think I did most of the changes here in rP484599.

Mk/Uses/ssl.mk
67	I think it'd be easier to add openssl111 to BROKEN_SSL if osversion >= 12000085 and SSL_DEFAULT is base, you would not have to dupplicate all the logic here.

Update after rP484599

Prevent constructs like https://github.com/freebsd/freebsd-ports/commit/93c9ec82

Harbormaster completed remote builds in B20736: Diff 50248.Nov 10 2018, 11:18 AM

brnrd retitled this revision from Mk/Uses/ssl.mk: Chase removal of openssl-devel to Mk/Uses/ssl.mk: Automate BROKEN for 12+.Nov 10 2018, 11:22 AM

brnrd edited the summary of this revision. (Show Details)

brnrd added a reviewer: mat.

brnrd removed a subscriber: mat.

I think it'd be easier to add openssl111 to BROKEN_SSL if osversion >= 12000085 and SSL_DEFAULT is base, you would not have to dupplicate all the logic here.

brnrd marked an inline comment as done.Nov 12 2018, 1:41 PM

brnrd added inline comments.

Mk/Uses/ssl.mk
67	Don't quite understand the comment. The top-most if-block is for `SSL_DEFAULT=base`, I don't see how adding `openssl111` somewhere would avoid duplicating the logic. The block processing `BROKEN_SSL` is never be run if SSL_DEFAULT is `base`.