Page MenuHomeFreeBSD

Mk/Uses/ssl.mk: Automate BROKEN for 12+
AbandonedPublic

Authored by brnrd on Nov 4 2018, 9:10 AM.

Details

Reviewers
mat
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary
Mk/Uses/ssl.mk: Automate BROKEN for 12+

 - Add BROKEN for FreeBSD 12+ when broken with openssl111

Differential_Revision:	https://reviews.freebsd.org/D17834

Currently all ports marked BROKEN_SSL= openssl111 also require BROKEN_FreeBSD_12 and BROKEN_FreeBSD_13 entries, but only if DEFAULT_VERSIONS=ssl isn't openssl. This requires ugly contstructs like https://github.com/freebsd/freebsd-ports/commit/93c9ec82

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20736
Build 20145: arc lint + arc unit

Event Timeline

brnrd created this revision.Nov 4 2018, 9:10 AM
brnrd marked an inline comment as done.Nov 8 2018, 5:32 PM
brnrd added inline comments.
Mk/Uses/ssl.mk
67
mat added a comment.Nov 10 2018, 10:50 AM

I think I did most of the changes here in rP484599.

Mk/Uses/ssl.mk
67

I think it'd be easier to add openssl111 to BROKEN_SSL if osversion >= 12000085 and SSL_DEFAULT is base, you would not have to dupplicate all the logic here.

brnrd retitled this revision from Mk/Uses/ssl.mk: Chase removal of openssl-devel to Mk/Uses/ssl.mk: Automate BROKEN for 12+.Nov 10 2018, 11:22 AM
brnrd edited the summary of this revision. (Show Details)
brnrd added a reviewer: mat.
brnrd removed a subscriber: mat.
mat added a comment.Nov 12 2018, 11:22 AM

I think it'd be easier to add openssl111 to BROKEN_SSL if osversion >= 12000085 and SSL_DEFAULT is base, you would not have to dupplicate all the logic here.

brnrd marked an inline comment as done.Nov 12 2018, 1:41 PM
brnrd added inline comments.
Mk/Uses/ssl.mk
67

Don't quite understand the comment.

The top-most if-block is for SSL_DEFAULT=base, I don't see how adding openssl111 somewhere would avoid duplicating the logic. The block processing BROKEN_SSL is never be run if SSL_DEFAULT is base.

brnrd abandoned this revision.Dec 15 2018, 12:03 PM

Overcome by D18449