Reduce mountd DNS queries
ClosedPublic
Actions

Authored by sef on Dec 4 2018, 10:12 PM.

Details

Reviewers

mav
imp

Commits

rS341641: Reduce number of DNS queries in mountd.

Summary

Right now, mountd does a getnameinfo call for every request, even ones where it doesn't use them. A FreeNAS user noticed this was resulting in large delays (due to a resolv.conf error); in looking at the code, there's no reason for it to call getnameinfo in most cases.

Test Plan

Export files via NFS, and ensure mounting on client works.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sef created this revision.Dec 4 2018, 10:12 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 4 2018, 10:12 PM

lgtm

This revision is now accepted and ready to land.Dec 4 2018, 10:21 PM

Generally looks good to me, except one cosmetic issue -- the line seems to go beyond 80 columns, so it would be nice to re-wrap it earlier.

Fix the larger-than-80-columns I got from using the wrong window for my editing.

This revision now requires review to proceed.Dec 6 2018, 2:37 AM

In D18430#392768, @mav wrote:

Generally looks good to me, except one cosmetic issue -- the line seems to go beyond 80 columns, so it would be nice to re-wrap it earlier.

Fixed!

mav accepted this revision.Dec 6 2018, 5:03 AM

This revision is now accepted and ready to land.Dec 6 2018, 5:03 AM

Closed by commit rS341641: Reduce number of DNS queries in mountd. (authored by sef). · Explain WhyDec 6 2018, 6:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

mountd/

mountd.c

9 lines

Diff 51637

View Options

Reduce mountd DNS queriesClosedPublicActions