Page MenuHomeFreeBSD

Reduce mountd DNS queries
ClosedPublic

Authored by sef on Tue, Dec 4, 10:12 PM.

Details

Summary

Right now, mountd does a getnameinfo call for every request, even ones where it doesn't use them. A FreeNAS user noticed this was resulting in large delays (due to a resolv.conf error); in looking at the code, there's no reason for it to call getnameinfo in most cases.

Test Plan

Export files via NFS, and ensure mounting on client works.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sef created this revision.Tue, Dec 4, 10:12 PM
This revision is now accepted and ready to land.Tue, Dec 4, 10:21 PM
mav added a comment.Wed, Dec 5, 8:04 PM

Generally looks good to me, except one cosmetic issue -- the line seems to go beyond 80 columns, so it would be nice to re-wrap it earlier.

sef updated this revision to Diff 51637.Thu, Dec 6, 2:37 AM

Fix the larger-than-80-columns I got from using the wrong window for my editing.

This revision now requires review to proceed.Thu, Dec 6, 2:37 AM
sef added a comment.Thu, Dec 6, 2:37 AM
In D18430#392768, @mav wrote:

Generally looks good to me, except one cosmetic issue -- the line seems to go beyond 80 columns, so it would be nice to re-wrap it earlier.

Fixed!

mav accepted this revision.Thu, Dec 6, 5:03 AM
This revision is now accepted and ready to land.Thu, Dec 6, 5:03 AM
This revision was automatically updated to reflect the committed changes.