Fix first-packet completion
ClosedPublic
Actions

Authored by shurd on Nov 28 2018, 3:25 PM.

Tags

None

Referenced Files

	F169663449: D18368.id51299.diff
	Wed, Sep 2, 5:32 AM

	Unknown Object (File)
	Fri, Aug 28, 5:18 AM

	Unknown Object (File)
	Thu, Aug 27, 2:41 PM

	Unknown Object (File)
	Tue, Aug 25, 12:22 AM

	Unknown Object (File)
	Sun, Aug 23, 2:20 AM

	Unknown Object (File)
	Mon, Aug 10, 10:48 AM

	Unknown Object (File)
	Mon, Aug 10, 10:30 AM

	Unknown Object (File)
	Jul 28 2026, 11:20 AM

View All Files

Subscribers

imp

jacob.e.keller_intel.com

Details

Reviewers

sbruno
lev
erj
jeb

Commits

rS341427: MFC r341156:
rS341156: Fix first-packet completion

Summary

The first packet after the ring is initialized was never
completed as isc_txd_credits_update() would not include it in the
count of completed packets. This caused netmap to never complete
a batch. See PR 233022 and 233607 for more details.

Test Plan

lev tests all the things!

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

shurd created this revision.Nov 28 2018, 3:25 PM

Herald added subscribers: ae, imp. · View Herald TranscriptNov 28 2018, 3:25 PM

Harbormaster completed remote builds in B21239: Diff 51289.Nov 28 2018, 3:25 PM

It helps for ix, can not test for ixl, as I don't have one/

This revision is now accepted and ready to land.Nov 28 2018, 3:28 PM

Closed by commit rS341156: Fix first-packet completion (authored by shurd). · Explain WhyNov 28 2018, 5:37 PM

This revision was automatically updated to reflect the committed changes.

I know I'm late commenting on this, but I think the correct fix is to initialize tx_cidx_processed to txr->desc_count -1 when we initialize.

head/sys/dev/ixl/ixl_txrx.c
523	Also, this MPASS seems very fishy. I don't think it's correct.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ixgbe/

ix_txrx.c

2 lines

ixl/

ixl_txrx.c

6 lines

Diff 51299

View Options

head/sys/dev/ixgbe/ix_txrx.c