Page MenuHomeFreeBSD

Please approve flavorization of ignition-* ports
AbandonedPublic

Authored by yuri on Nov 21 2018, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 12 2024, 10:19 AM
Unknown Object (File)
Dec 20 2023, 1:16 AM
Unknown Object (File)
Dec 13 2023, 3:59 AM
Unknown Object (File)
Nov 30 2023, 7:01 AM

Details

Reviewers
None
Summary

Ignition robotics framework allows to install individual packages simultaneously in different versions.The top app that uses the ignition framework will be 'gazebo'.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21155
Build 20513: arc lint + arc unit

Event Timeline

yuri retitled this revision from ignition robotics framework allows to install individual packages simultaneously in different versions. The top app that uses the ignition framework will be 'gazebo'. to Please approve flavorization of ignition-* ports.Nov 21 2018, 8:08 PM
yuri edited the summary of this revision. (Show Details)

This seems like an abuse of flavors. Flavors are for building different variants of a single version, not multiple different versions.

How would patch files work with multiple flavors in play?

devel/ignition-cmake/Makefile
30–31

.elif or just .else

devel/ignition-common/Makefile
42–43

.elif ?

48–49

.elif or just .else

devel/ignition-msgs/Makefile
34–35

.elif ?

devel/ignition-transport/Makefile
41–42

.elif or just .else

math/ignition-math/Makefile
32–33

.elif or just .else

43–44
CMAKE_ON= CMAKE_DISABLE_FIND_PACKAGE_SWIG
misc/sdformat/Makefile
39–40

.elif or just .else

This seems like an abuse of flavors. Flavors are for building different variants of a single version, not multiple different versions.

They chose to manage versions this way. It's better to contain them as flavors vs. to generate a lot of separate port directories.

How would patch files work with multiple flavors in play?

Patches are in individual patch directories (files-vN/).

In D18293#388008, @yuri wrote:

Patches are in individual patch directories (files-vN/).

Ah ok, I somehow missed that PATCHDIR was set for this in a couple of ports.

No on flavors which produce different versions of the software.